-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: HTTP Server #368
Example: HTTP Server #368
Conversation
I'll fix the formatting |
b4c64c2
to
424de70
Compare
Cool example. It will be really nice if you could add also a: /drawjpg endpoint, that will receive the JPG file, decompress it and draw it on the display but knowing that you make a Python Client is also ok. It’s just that this way could be easier for someone to send a JPG image from anywhere including a browser of any mobile device. |
Thanks for the idea, I'll have a look. If adding JPG support will be easy, I'll do it |
On a second thought, would you mind merging it now, and we can add the jpg endpoint later? |
Looks interesting! I'll have a closer look and try it out hopefully later this week :) |
A bit of early feedback from my side here:
This is because is not taking esp32s3 as default target. sdkconfig.defaults should point to ESP32S3 target that is the last PCB. My advice, just copy: sdkconfig.defaults.esp32s3 to sdkconfig.defaults so the user can directly compile this for the last v7 PCB.
This could be ideally reduced to one settings.h header file or just one of them, where you can edit a single file and just build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible check my comments and the mentions done by another reviewers of the code
thank you all for the feedback! |
7254f88
to
14c9ccb
Compare
14c9ccb
to
5b86793
Compare
Runs an HTTP server that will draw images on the screen. Useful for setting up a small digital frame that can be remotely controlled.
5b86793
to
26ca491
Compare
hello @BackSlasher please do not force push like this because is hard to follow history. Usually you force push something when you want to go back to a certain point but not when you go forward correcting stuff. |
I have no problem adapting to what's convenient to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @vroland if you want to try it go ahead, I like the example, and maybe at some point will contribute adding pure JPG decoding ability
I have plans to test this further as soon as my boards arrive. |
Regarding the force-pushing: I don't have a problem with this, do whatever you want in the PR; I squash before merge anyway ;) |
Runs an HTTP server that will draw images on the screen. Useful for setting up a small digital frame that can be remotely controlled.
Has a friendly Python client,
Video:
https://github.com/user-attachments/assets/dd4d095b-7b5a-4d57-b403-6f1afc7d6c81